Incorrect ruler length with shuffleListeners query parameter

[veillette]

As part of the work on #129, we found that run the simulation with the query parameters ea&shuffleListeners lead to an unexpected behavior.

Putting a ruler within the playArea and zooming out leas to a ruler that is twice as long as expected.

[pixelzoom]

It would not be tragic if this sim did not support ?shuffleListeners. So I'm going to unassign this for now, and we can decide whether we want to spend time on it when we get closer to public deployment.

[pixelzoom]

The problem is in GeometricOpticsRulerNode:

    zoomScaleProperty.link( zoomScale => {

      // update model length, so that view length remains the same
      ruler.scaleLength( zoomScale );

      // update view
      this.removeAllChildren();
      this.addChild( createRulerNode( this.ruler.length, zoomTransformProperty.value, zoomScale, options.rulerOptions ) );
    } );

This listener depends on zoomScaleProperty and zoomTransformProperty, but is only listenening to zoomScaleProperty. It assumes that zoomTransformProperty is updated before zoomScaleProperty.

[pixelzoom]

The rulers went through a major rewrite. But this is still a problem, as indicated by this TODO in GORulerNode.js:

    //TODO https://github.com/phetsims/geometric-optics/issues/133 this listener also depends on zoomTransformProperty, so there's a problematic ordering dependency there
    zoomScaleProperty.link( zoomScale => {

[pixelzoom]

Fixed in the above commit, tested with shuffleListeners, closing.