Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to examples.md #285

Closed
1 task done
Tracked by #1123 ...
Nancy-Salpepi opened this issue Jul 15, 2024 · 16 comments
Closed
1 task done
Tracked by #1123 ...

Changes to examples.md #285

Nancy-Salpepi opened this issue Jul 15, 2024 · 16 comments

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Jul 15, 2024

  • Under "Hide one type of Particles" change:
    gasProperties.idealScreen.view.viewProperties.particleTypeProperty to gasProperties.energyScreen.view.viewProperties.particleTypeProperty

I will continue to add to this issue if I find anything else.

@Nancy-Salpepi
Copy link
Author

Tagging phetsims/qa#1107

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 15, 2024

@arouinfar Please consider waiting until you have a complete list of changes related to phetsims/qa#1107, and making those changes as one commit to gas-properties main. Since we're in RC testing, that commit will need to be patched into new branches of phet-io-sim-specific for gas-properties, gases-intro, and diffusion. I'll be happy to handle the patching, but dealing with 1 commit would make my life easier.

@Nancy-Salpepi
Copy link
Author

Nancy-Salpepi commented Jul 16, 2024

These need to be featured:
gasProperties.diffusionScreen.view.panels.settingsPanel.numberOfParticlesControls.visibleProperty
gasProperties.diffusionScreen.view.panels.settingsPanel.massControls.visibleProperty
gasProperties.diffusionScreen.view.panels.settingsPanel.radiusControls.visibleProperty
gasProperties.diffusionScreen.view.panels.settingsPanel.initialTemperatureControls.visibleProperty

@pixelzoom edit: Tracking in #286.

@Nancy-Salpepi
Copy link
Author

Nancy-Salpepi commented Jul 16, 2024

For Gases Intro (phetsims/qa#1108):

  • Make the 'l' in LawScreen lowercase in the code snippet under Access raw particle data

@Nancy-Salpepi
Copy link
Author

For Diffusion (phetsims/qa#1109) the examples.md looks good.
The visibleProperty for the diffusion variables has been fixed in #286

@arouinfar
Copy link
Contributor

arouinfar commented Jul 19, 2024

  • The Maxwell-Boltzmann distribution example should refer clients to temperature data instead of speed data.

@pixelzoom
Copy link
Contributor

Looks like QA has completed phetsims/qa#1107, so @arouinfar can proceed with making changes. Assign to me when you're done, and I'll cherry-pick.

@arouinfar
Copy link
Contributor

Thanks @Nancy-Salpepi! I've made the 3 changes identified in this issue along with some minor formatting tweaks. The Diffusion sim did not require any changes.

@pixelzoom the above commits are ready to cherry-pick.

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 22, 2024

Release branches are patched. Ready for verification in 1.1.0-rc.2, for gas-properties and gases-intro. There were no examples.md changes for diffusion.

@pixelzoom
Copy link
Contributor

Please verify for phetsims/qa#1123 and phetsims/qa#1124. (There were no changes for the Diffusion sim.)

If everything looks OK, please close this issue.

@Nancy-Salpepi
Copy link
Author

Changes look good in rc.2 for Gas Properties and Gases Intro.
Closing.

@KatieWoe
Copy link
Contributor

In the example doc for Gases Intro, there were some properties with incorrect capitalization. This does not impact searching.
caps
From Slack:

Amy Rouinfar

Since it doesn't affect searching, I'm inclined to leave it alone, assuming there isn't anything else to fix.
Regardless, reopen the issue because it should get fixed on main, even if we decide not to patch

@KatieWoe KatieWoe reopened this Jul 30, 2024
@Nancy-Salpepi
Copy link
Author

Oh man! Sorry I missed that @arouinfar!

@pixelzoom pixelzoom self-assigned this Jul 30, 2024
@pixelzoom
Copy link
Contributor

@arouinfar and I discussed. I fixed in the above commit, will cherry-pick next. We don't feel this is worthy of QA's time, and the QA Pipeline overfloweth. If no other problems are found, I'll publish 1.1.0-rc.3 and have @arouinfar verify, then publish production.

pixelzoom added a commit to phetsims/gases-intro that referenced this issue Jul 30, 2024
@pixelzoom
Copy link
Contributor

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Jul 30, 2024
@arouinfar
Copy link
Contributor

Looks good in rc.3, closing.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants