-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to examples.md #285
Comments
Tagging phetsims/qa#1107 |
@arouinfar Please consider waiting until you have a complete list of changes related to phetsims/qa#1107, and making those changes as one commit to gas-properties main. Since we're in RC testing, that commit will need to be patched into new branches of phet-io-sim-specific for gas-properties, gases-intro, and diffusion. I'll be happy to handle the patching, but dealing with 1 commit would make my life easier. |
These need to be featured: @pixelzoom edit: Tracking in #286. |
For Gases Intro (phetsims/qa#1108):
|
For Diffusion (phetsims/qa#1109) the examples.md looks good. |
|
Looks like QA has completed phetsims/qa#1107, so @arouinfar can proceed with making changes. Assign to me when you're done, and I'll cherry-pick. |
Thanks @Nancy-Salpepi! I've made the 3 changes identified in this issue along with some minor formatting tweaks. The Diffusion sim did not require any changes. @pixelzoom the above commits are ready to cherry-pick. |
Release branches are patched. Ready for verification in 1.1.0-rc.2, for gas-properties and gases-intro. There were no examples.md changes for diffusion. |
Please verify for phetsims/qa#1123 and phetsims/qa#1124. (There were no changes for the Diffusion sim.) If everything looks OK, please close this issue. |
Changes look good in rc.2 for Gas Properties and Gases Intro. |
Oh man! Sorry I missed that @arouinfar! |
@arouinfar and I discussed. I fixed in the above commit, will cherry-pick next. We don't feel this is worthy of QA's time, and the QA Pipeline overfloweth. If no other problems are found, I'll publish 1.1.0-rc.3 and have @arouinfar verify, then publish production. |
@arouinfar please verify in https://phet-dev.colorado.edu/html/gases-intro/1.1.0-rc.3/phet-io/. Close if OK. |
gasProperties.idealScreen.view.viewProperties.particleTypeProperty
togasProperties.energyScreen.view.viewProperties.particleTypeProperty
I will continue to add to this issue if I find anything else.
The text was updated successfully, but these errors were encountered: