Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepping forward in upstream sim while paused doesn't change state of downstream sim #280

Closed
Nancy-Salpepi opened this issue Jun 26, 2024 · 3 comments

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Jun 26, 2024

Test device
MacBook Air M1 chip and iPad

Operating System
14.5 and 17.5.1

Browser
Safari 17.5

Problem description
For phetsims/qa#1100, while trying to replicate #282 I came across another issue that occurs while paused.
In the state wrapper, on any screen, if you use the step forward button in the upstream sim the particles do not update in the downstream sim.

Steps to reproduce

  1. In the state wrapper, on any screen press Pause in the upstream sim
  2. Add some particles
  3. Continuously press the Step Forward button--the particles do not update in the downstream sim.

Visuals
Screenshot 2024-06-25 at 8 45 48 PM
Screenshot 2024-06-25 at 8 51 56 PM

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 3, 2024

Reproduced in main.

Note that #276 and #280 are both bad State Wrapper behavior when the sim is paused, and both related to the position of particles.

This is probably related to incorrect or missing use(s) of isSettingPhetioStateProperty, in relation to isPlayingProperty.

@pixelzoom
Copy link
Contributor

This was fixed by 98b2d2d over in #276. (I love it when that happens.)

@Nancy-Salpepi please verify, close if OK.

@Nancy-Salpepi
Copy link
Author

yup! This guy is fixed too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants