-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lid is not resized when sim is paused. #269
Comments
Relevant bits of code are in IdealGasLawContainer.ts: |
@Nancy-Salpepi please review, close if OK. @arouinfar feel free to have a look too. Details: The problem here is that while the lid looks like it is still on the container, it is actually off of the container, but has not yet begun its "spinning" animation. And when the lid is off of the container, resizing the container does not resize the lid. So the sim is actually behaving correctly, but what we're showing is confusing. I discussed this with @arouinfar, and a reasonable change is to immediately move the lid up a bit (10 pixels seems sufficient) when the "Return Lid" button is made visible. The lid animation will then start from this position. That has been implemented in 8be84b9. So following the steps in #269 (comment) will now look like the screenshots below. This (hopefully) makes it clear that the lid is not on the container, and eliminates the expectation that the lid should resize when the container is resized. |
Working as you described. |
Reported by @Nancy-Salpepi. This is not a new problem, and occurs in the 1.0 production version, as well as in main.
Steps to reproduce:
The text was updated successfully, but these errors were encountered: