Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA doesn't read descriptions until key is released #296

Closed
Nancy-Salpepi opened this issue Apr 6, 2022 · 11 comments
Closed

NVDA doesn't read descriptions until key is released #296

Nancy-Salpepi opened this issue Apr 6, 2022 · 11 comments

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Apr 6, 2022

Test device
Dell

Operating System
Win10

Browser
Firefox

Problem description
For phetsims/qa#791, when a WASD key or arrow key is held down to move the book, NVDA doesn't read out any descriptions. No descriptions are read out until I release the key, but this results in many descriptions being missed.
This does not match was happens with VO or what I see in ally view.

Steps to reproduce

  1. With NVDA on, move the book all the way to one side keeping the key held down.
  2. Release the key

Visuals

NVDAfriction.mov
@stemilymill
Copy link

The behavior is the same on Win10 chrome + JAWS

@zepumph
Copy link
Member

zepumph commented Jun 1, 2022

This is actually the behavior that we expect to see. I'm not sure how your results differ in VO, but in general you only get description upon the end of an interaction, not during it. It is most typical for a user to move more judiciously to receive info as they go. Can you please describe the behavior of VO, if it it seems buggy given this information?

@zepumph zepumph assigned stemilymill and Nancy-Salpepi and unassigned zepumph Jun 1, 2022
@Nancy-Salpepi
Copy link
Author

Nancy-Salpepi commented Jun 4, 2022

@zepumph I am not hearing any responsive descriptions at all when I move the book except for "right/left". Something else must be wrong at the moment, but I don't see anything in the console. Perhaps it is related to the assertion error I mentioned in #277 (comment)

responsivedescriptions.mov

@zepumph
Copy link
Member

zepumph commented Jun 6, 2022

Weird! @Nancy-Salpepi I am able to get everything in the a11y view, but not in the main sim. I'll have to investigate.

@zepumph
Copy link
Member

zepumph commented Jun 6, 2022

I believe that phetsims/utterance-queue@b18b258 is the culprit.

@zepumph
Copy link
Member

zepumph commented Jun 6, 2022

That commit was NOT the cuplrit. @jessegreenberg and I investifated and bugs reported and to be fixed in phetsims/utterance-queue#82.

@Nancy-Salpepi, marking this on hold until you can test description again.

@zepumph
Copy link
Member

zepumph commented Jun 6, 2022

Ok, we should have description back in Friction. @Nancy-Salpepi can you please take this issue from #296 (comment).

@Nancy-Salpepi
Copy link
Author

@zepumph I'm still not getting any description with Friction on master (I cleared my history and am in an a private window).

@Nancy-Salpepi
Copy link
Author

@zepumph I start to hear alerts with VO while still holding down a key. This is how VO has always behaved for me (I think). I see the same thing in John Travoltage.

frictionVO.mov

@zepumph
Copy link
Member

zepumph commented Jun 10, 2022

As far as I know this is just a difference between screen readers, and not something to investigate. I also poked around the internet and didn't find anything. I see that the response is making it to the screen reader (NVDA menu -> tools -> speech viewer), but then keeping the key down immediately silences it. @jessegreenberg can you confirm that this different isn't a bug? I'm happy to investigate further if you disagree.

@zepumph zepumph assigned jessegreenberg and unassigned zepumph Jun 10, 2022
@zepumph
Copy link
Member

zepumph commented Jun 24, 2022

@terracoda and I discussed this today, we agree this isn't a bug. @Nancy-Salpepi please note this discrepancy between screen readers. Nothing to change here. Closing

@zepumph zepumph closed this as completed Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants