Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra interactive highlights #277

Closed
Nancy-Salpepi opened this issue Mar 30, 2022 · 3 comments
Closed

Extra interactive highlights #277

Nancy-Salpepi opened this issue Mar 30, 2022 · 3 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.3

Browser
safari/chrome

Problem description
For phetsims/qa#791 there seems to be extraneous interactive highlights--a pink line appears across the entire screen and the physics book also has one.

Steps to reproduce

  1. Turn on interactive highlights
  2. Move mouse around the screen and over different objects

Visuals

interactivehighlights.mp4
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Friction‬ URL: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.24/phet/friction_all_phet.html Version: 1.6.0-dev.24 2022-03-30 15:06:07 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.84 Safari/537.36 Language: en-US Window: 1431x690 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@zepumph
Copy link
Member

zepumph commented Jun 1, 2022

It has been a while here, but this should not be fixed. Can you please confirm. There should no longer be an interactive highlight around the entire, huge, magnifierNode, and also around the physics book (which isn't interactive either).

@Nancy-Salpepi
Copy link
Author

@zepumph I no longer see the interactive highlights around the entire magnifierNode or physics book in the PhET brand sim or PhET-iO standalone sim.
When I tried to turn on interactive highlights in studio, there was an assertion error which froze studio.
Screen Shot 2022-06-04 at 7 05 22 AM

@zepumph
Copy link
Member

zepumph commented Jun 6, 2022

I created phetsims/joist#817 to investigate that. It seems separate, thanks for the report though! I'm going to close this issue. Please reopen if needed.

@zepumph zepumph closed this as completed Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants