Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move soccer common repo outside of CaV #374

Closed
marlitas opened this issue Jul 20, 2023 · 12 comments
Closed

Move soccer common repo outside of CaV #374

marlitas opened this issue Jul 20, 2023 · 12 comments

Comments

@marlitas
Copy link
Contributor

This is the last remaining work for: #222

We want to wait until development is done to do this so that we don't have to deal with cross repo commits as often.

marlitas added a commit to phetsims/perennial that referenced this issue Aug 2, 2023
marlitas added a commit to phetsims/phet-info that referenced this issue Aug 2, 2023
marlitas added a commit that referenced this issue Aug 3, 2023
marlitas added a commit to phetsims/chipper that referenced this issue Aug 3, 2023
marlitas added a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas added a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas added a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas added a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas added a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas added a commit that referenced this issue Aug 3, 2023
@marlitas
Copy link
Contributor Author

marlitas commented Aug 3, 2023

Soccer Common is now a separate repo. Imports seem to be working well overall. Keeping this issue open for a few days to ensure everything is good to go. Also sending to @samreid and @matthew-blackman for review.

@samreid
Copy link
Member

samreid commented Aug 3, 2023

What strategy was used to migrate the repo? It seems like the history stops at June 9 2023 in 1802160 as if it could not track the moves prior to that commit.

@marlitas
Copy link
Contributor Author

marlitas commented Aug 3, 2023

I used copy-history-to-different-repo.js in perennial and also double checked that I saw a git history before committing and merging.

@marlitas
Copy link
Contributor Author

marlitas commented Aug 3, 2023

I think many of these files were new when we did the original refactoring to SoccerCommon which might explain the June 9th date.

@samreid
Copy link
Member

samreid commented Aug 8, 2023

The commits above look good. I don't why our tooling lost history before June 9, 2023 and I don't know how much time it is worth to spend on it. I tried looking into the history to see why something is unexpectedly private for #431 and I run into the June 9 dead-end. I also think we need to add implementation notes and model.md, and ideally (if there's time) an example main usage for this repo. @marlitas what do you think?

@samreid samreid assigned marlitas and unassigned samreid Aug 8, 2023
@marlitas
Copy link
Contributor Author

marlitas commented Aug 8, 2023

I think adding an implementation-notes.md, model.md, and example main are good ideas. I'll create some placeholders for those now.

@marlitas
Copy link
Contributor Author

marlitas commented Aug 8, 2023

So implementation-notes.md and model.md templates are already in there. I tried looking for examples of an example main and I couldn't find any... I'm not exactly sure what I should be creating for that...

Or were you recommending we fill those in as part of this issue @samreid?

@marlitas marlitas assigned samreid and unassigned marlitas Aug 8, 2023
@samreid
Copy link
Member

samreid commented Aug 8, 2023

I feel this issue can be closed. Would you recommend we open new issues for writing the documentation and creating a sample usage?

I tried looking for examples of an example main and I couldn't find any... I'm not exactly sure what I should be creating for that...

For instance, bamboo is a common code repo that has a sample main.

@samreid samreid assigned marlitas and unassigned samreid Aug 8, 2023
@marlitas
Copy link
Contributor Author

marlitas commented Aug 9, 2023

Would you recommend we open new issues for writing the documentation and creating a sample usage?

Sounds good. Issues are: #442, #443

For instance, bamboo is a common code repo that has a sample main.

I am very confused... I searched bamboo and could not find a file with sample or main or any other file that seemed might fill that space. I noticed there is a demo directory, but that seems unnecessary for soccer-common.

@marlitas
Copy link
Contributor Author

marlitas commented Aug 9, 2023

Otherwise I think this issue can be closed.

@marlitas marlitas assigned samreid and unassigned marlitas Aug 9, 2023
@samreid
Copy link
Member

samreid commented Aug 9, 2023

For instance: http://localhost/bamboo/bamboo_en.html or you can select it from phetmarks

@samreid samreid assigned marlitas and unassigned samreid Aug 9, 2023
@marlitas
Copy link
Contributor Author

Ahh I see. I'm not sure it is necessary for soccer-common to have a demo. That feels like an enhancement we can undertake down the line we start to see a whole suite of sims using soccer-common, but doesn't seem necessary for the purposes of CaV and MSaB.

I'm going to go ahead and close, but @samreid feel free to re-open if you feel differently.

samreid pushed a commit to phetsims/soccer-common that referenced this issue Aug 25, 2023
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants