-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move soccer common repo outside of CaV #374
Comments
Soccer Common is now a separate repo. Imports seem to be working well overall. Keeping this issue open for a few days to ensure everything is good to go. Also sending to @samreid and @matthew-blackman for review. |
What strategy was used to migrate the repo? It seems like the history stops at June 9 2023 in 1802160 as if it could not track the moves prior to that commit. |
I used |
I think many of these files were new when we did the original refactoring to SoccerCommon which might explain the June 9th date. |
The commits above look good. I don't why our tooling lost history before June 9, 2023 and I don't know how much time it is worth to spend on it. I tried looking into the history to see why something is unexpectedly private for #431 and I run into the June 9 dead-end. I also think we need to add implementation notes and model.md, and ideally (if there's time) an example main usage for this repo. @marlitas what do you think? |
I think adding an implementation-notes.md, model.md, and example main are good ideas. I'll create some placeholders for those now. |
So implementation-notes.md and model.md templates are already in there. I tried looking for examples of an example main and I couldn't find any... I'm not exactly sure what I should be creating for that... Or were you recommending we fill those in as part of this issue @samreid? |
I feel this issue can be closed. Would you recommend we open new issues for writing the documentation and creating a sample usage?
For instance, bamboo is a common code repo that has a sample main. |
Sounds good. Issues are: #442, #443
I am very confused... I searched bamboo and could not find a file with |
Otherwise I think this issue can be closed. |
For instance: http://localhost/bamboo/bamboo_en.html or you can select it from phetmarks |
Ahh I see. I'm not sure it is necessary for soccer-common to have a demo. That feels like an enhancement we can undertake down the line we start to see a whole suite of sims using soccer-common, but doesn't seem necessary for the purposes of CaV and MSaB. I'm going to go ahead and close, but @samreid feel free to re-open if you feel differently. |
This is the last remaining work for: #222
We want to wait until development is done to do this so that we don't have to deal with cross repo commits as often.
The text was updated successfully, but these errors were encountered: