Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move soccer context to a common repo #222

Closed
marlitas opened this issue May 26, 2023 · 9 comments
Closed

Move soccer context to a common repo #222

marlitas opened this issue May 26, 2023 · 9 comments

Comments

@marlitas
Copy link
Contributor

marlitas commented May 26, 2023

The fourth screen in Mean: Share and Balance will now have a soccer context as well. This means we need to move out the following pieces to a common repo that can be shared between the two sims.

  • SoccerBallNode
  • SoccerPlayerNode
  • CAVObjectNode
  • NumberLineNode?
  • CAVPlotNode?
  • SoccerBall
  • SoccerPlayer
  • Pose
  • AnimationMode
  • ObjectType?
@marlitas marlitas changed the title Move soccer context to a common repo (sharing with MSaB in the future) Move soccer context to a common repo May 26, 2023
@samreid samreid self-assigned this Jun 8, 2023
@samreid
Copy link
Member

samreid commented Jun 8, 2023

Maybe call it soccer-common? And make sure to preserve history via copy-history-to-different-repo.js

marlitas added a commit that referenced this issue Jun 9, 2023
@marlitas
Copy link
Contributor Author

marlitas commented Jun 9, 2023

I went through the model files and added TODO's to try and organize what classes along with their properties that will need to be moved out. I think there's some conversation on the exact strategy we feel would be best to move this forward. Probably good to discuss together first.

@samreid
Copy link
Member

samreid commented Jun 9, 2023

@marlitas and I started on creating a soccer-common/ subdirectory so we can get things organized before changing repos. I'm continuing to search for which files are relevant, by checking imports.

samreid added a commit that referenced this issue Jun 9, 2023
samreid added a commit that referenced this issue Jun 9, 2023
samreid added a commit that referenced this issue Jun 9, 2023
samreid added a commit that referenced this issue Jun 9, 2023
samreid added a commit that referenced this issue Jun 10, 2023
samreid added a commit that referenced this issue Jun 10, 2023
samreid added a commit that referenced this issue Jun 10, 2023
@samreid
Copy link
Member

samreid commented Jun 10, 2023

After the commits above, there are 3 remaining imports from outside of soccer-common. You can search them using this regex: \'\.\.\/\.\.\/\w

Also, when we move soccer-common to a separate repo, we will incur overhead for committing in 2x repos, type checking 2x repos, linting 2x repos, branching would become more difficult, issues will be managed in 2x repos. The project board will need to know how to work with 2x repos, etc. So I considered we may want to add a lint rule like the regex above and keep working with soccer-common embedded in center-and-variability/ a bit longer.

Also, it seems we should either add (a) a test harness for soccer-common or (b) initial draft of mean-share-and-balance usage, so we can make sure it is suitable for reuse.

@samreid samreid added the dev:help-wanted Extra attention is needed label Jun 10, 2023
@samreid samreid removed their assignment Jun 10, 2023
marlitas added a commit that referenced this issue Jun 12, 2023
marlitas added a commit that referenced this issue Jun 12, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas added a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas added a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas added a commit to phetsims/soccer-common that referenced this issue Aug 3, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 23, 2023
marlitas pushed a commit to phetsims/soccer-common that referenced this issue Aug 23, 2023
marlitas added a commit to phetsims/soccer-common that referenced this issue Aug 23, 2023
samreid added a commit to phetsims/soccer-common that referenced this issue Aug 25, 2023
zepumph pushed a commit to phetsims/perennial that referenced this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants