Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bootstrap to pharo7 #4558

Merged
merged 11 commits into from
Nov 15, 2019
Merged

Update bootstrap to pharo7 #4558

merged 11 commits into from
Nov 15, 2019

Conversation

carolahp
Copy link
Contributor

And migrated PharoBootstrapProcess libraries to Tonel

jecisc
jecisc approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@jecisc jecisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error not related

@jecisc
Copy link
Member

jecisc commented Sep 25, 2019

Bump

@Ducasse
Copy link
Member

Ducasse commented Sep 26, 2019

Hi guille
can you have a look?

@weekly-digest weekly-digest bot mentioned this pull request Sep 30, 2019
Closed
guillep
guillep approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good. If it breaks something we can always revert it.

@carolahp can you check the comment on the PharoBootstrap repository?

bootstrap/scripts/2-download.sh
${BOOTSTRAP_REPOSITORY}/bootstrap/scripts/getPharoVM.sh 61
wget --progress=dot:mega https://github.com/guillep/PharoBootstrap/releases/download/v1.5.0/bootstrapImage.zip
${BOOTSTRAP_REPOSITORY}/bootstrap/scripts/getPharoVM.sh 70
wget --progress=dot:mega https://github.com/carolahp/PharoBootstrap/releases/download/v1.7.0/bootstrapImage.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caro, it would be good if you make a PR to the original repository. We can move it under pharo-project/PharoBootstrap too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillep I did a PR to your repo
By "moving it to pharo-project/PharoBootstrap", you mean to create a new repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I meant that we can transfer the repository from my user to pharo's user

@carolahp carolahp mentioned this pull request Oct 2, 2019
Merged
@MarcusDenker
Copy link
Member

So what is the status?

@MarcusDenker
Copy link
Member

There seems to be conflicts now, too. I general, we need to merge faster. E.g. we could have merged and done a second pass to make it perfect.

@noha
Copy link
Member

noha commented Nov 13, 2019

I resolved the conflict and made a PR for carolas fork. If she accepts this should be mergable again

@carolahp
Copy link
Contributor Author

carolahp commented Nov 13, 2019 via email •
edited
Loading

@noha
Copy link
Member

noha commented Nov 15, 2019

error is not related to this PR. The OSX slave did not build properly

@Ducasse Ducasse merged commit 3a0b722 into pharo-project:Pharo8.0 Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillep guillep guillep approved these changes

@jecisc jecisc jecisc approved these changes

Assignees

@guillep guillep

Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@carolahp @jecisc @Ducasse @MarcusDenker @noha @guillep