Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pharo70 #8

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Conversation

carolahp
Copy link
Collaborator

@carolahp carolahp commented Oct 1, 2019

Espell version updated.
This version runs in Pharo70

@guillep guillep merged commit f61e2e5 into pharo-project:master Oct 2, 2019
@guillep
Copy link
Member

guillep commented Oct 2, 2019

It seems these commits were already there... This means we should probably generate an image and put it in the releases in this repo. Should we?

@carolahp
Copy link
Collaborator Author

carolahp commented Oct 2, 2019

Yes we should, unless we decide to move it to a repo under a pharo-project account.
Who has access to that account? After we generate the image we must remember to update the reference in pharo-project/pharo#4558 (review)

@guillep
Copy link
Member

guillep commented Oct 2, 2019

Yes we should, unless we decide to move it to a repo under a pharo-project account.

It does not really matter. We can transfer the repository in its entirety, with releases, issues and PRs.

Who has access to that account?

I do

After we generate the image we must remember to update the reference in pharo-project/pharo#4558 (review)

Let's do a todo list.
1- The first point you've already done it in your repo, don't you. I can just upload that file into my this repo.
2- I can do the transfer
3- Once I'm done with that, could you make that pull request?

@carolahp
Copy link
Collaborator Author

carolahp commented Oct 3, 2019

Let's do a todo list.
1- The first point you've already done it in your repo, don't you. I can just upload that file into my this repo.

Yes, the file is here so you can upload it

2- I can do the transfer

Ok

3- Once I'm done with that, could you make that pull request?

Of course, I will be waiting then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants