Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding check to fix when the image is open with an older VM #642

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Adding check to fix when the image is open with an older VM #642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions smalltalksrc/VMMaker/VMRememberedSet.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,15 @@ VMRememberedSet >> initialize [
VMRememberedSet >> initializeRememberedSetShouldStartEmpty: shouldStartEmpty [
| obj |
obj := self objectOop.

(manager isInOldSpace: obj)
ifFalse: [
manager logWarn: 'Remembered Set is in an invalid position %p. Signal of a corrupted root table.' _: obj.
shouldStartEmpty
ifTrue: [
obj := manager nilObject.
manager logWarn: 'As it starts empty, we can ignore it' ]].
Comment on lines +171 to +174
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it should not start empty, there is nothing to do and eventually will crash, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe it needs to just hard quit?


obj = manager nilObject
ifTrue:
[obj := manager allocatePinnedSlots: 1024.
Expand Down