Adding check to fix when the image is open with an older VM #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upts the remembered set.
|
@tesonep What was the problem? Loading a new image (with perm space) using an old VM (without perm space support) breaks the (perm space I guess) Remembered Set. Right? Is it because the new VM has a special behaviour to save/load the RS into/from the image? |
|
@PalumboN not only when it has perm space, also when the remembered set of the old space is not correctly updated. So if you have an image, you open with the new VM, then open with an old VM, and then the new... puum |
PalumboN
approved these changes
Jul 5, 2023
Comment on lines
+171
to
+174
| shouldStartEmpty | ||
| ifTrue: [ | ||
| obj := manager nilObject. | ||
| manager logWarn: 'As it starts empty, we can ignore it' ]]. |
There was a problem hiding this comment.
If it should not start empty, there is nothing to do and eventually will crash, right?
There was a problem hiding this comment.
Yes, maybe it needs to just hard quit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding check to fix when the image is open with an older VM that corrupts the remembered set.