-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admiral 0.11.0 #1937
Merged
admiral 0.11.0 #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentation guide, including CRCLBL and EGFRBL which depend on #1826 Calculate Creatinine Clearance
…tps://github.com/pharmaverse/admiral into 1822_implement_derive_param_extreme_record@devel
…rmaverse/admiral into 1772_Create_template_for_ADPPK@devel
… to ensure that the additonal 'Note' section is shown. Update using `devtools::document()`.
…-filter_exist.R Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
…harmaverse/admiral into 1699_create_filter_exist@devel
…tps://github.com/pharmaverse/admiral into 1822_implement_derive_param_extreme_record@devel
…s_convert_blanks_to_na@devel Closes #1709 use study data examples for convert_na_to_blanks and convert_blanks_to_na
…omputed@devel Closes #1873 enhance `derive_param_computed()`
…github.com/pharmaverse/admiral into 1903_new_contributors_to_description@devel
…name@devel Closes #1796 derive var basetype rename@devel
zdz2101
approved these changes
Jun 5, 2023
Closes #1919 Remove styler from DESCRIPTION
…scription@devel Closes #1903 adding new authors and address possbile missing news blurbs
* renv update from pharmaverse/admiralci * renv update from pharmaverse/admiralci * Run workflows --------- Co-authored-by: dgrassellyb <dgrassellyb@users.noreply.github.com> Co-authored-by: Ben Straub <ben.x.straub@gsk.com> Co-authored-by: cicdguy <cicdguy@users.noreply.github.com> Co-authored-by: cicdguy <26552821+cicdguy@users.noreply.github.com>
…armaverse/admiral into 1796_derive_var_basetype_rename@devel
…armaverse/admiral into 1796_derive_var_basetype_rename@devel
…name@devel Closes #1796 derive_var_basetype_rename: update templates
bundfussr
approved these changes
Jun 6, 2023
zdz2101
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()