Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Deprecate derive_var*_last_dose*() functions #1797

Closed
bundfussr opened this issue Mar 6, 2023 · 0 comments · Fixed by #1828
Closed

Feature Request: Deprecate derive_var*_last_dose*() functions #1797

bundfussr opened this issue Mar 6, 2023 · 0 comments · Fixed by #1828
Assignees
@zdz2101
Labels
enhancement New feature or request programming

Comments

@bundfussr
Copy link
Collaborator

Feature Idea

The derive_var*_last_dose*() functions should be deprecated in favor of derive_vars_joined().

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response
@sadchla-codes sadchla-codes mentioned this issue Mar 10, 2023
Closed
@zdz2101 zdz2101 self-assigned this Mar 17, 2023
@zdz2101 zdz2101 moved this from Priority to In Progress in admiral (sdtm/adam, dev, ci, template, core) Mar 20, 2023
zdz2101 pushed a commit that referenced this issue Apr 28, 2023
#1797 add back old code but still include deprecate_warn
4cc756d
zdz2101 pushed a commit that referenced this issue Apr 28, 2023
#1797 address merge conflict
bf296b6 
Merge branch 'devel' into 1797_deprecate_derive_var_last_dose@devel

# Conflicts:
#	man/derive_derived_param.Rd
#	man/derive_param_first_event.Rd
#	man/derive_var_agegr_fda.Rd
#	man/derive_vars_merged_dt.Rd
#	man/derive_vars_merged_dtm.Rd
#	man/filter_confirmation.Rd
#	man/vars.Rd
zdz2101 pushed a commit that referenced this issue Apr 28, 2023
#1797 address man pages
8030007
@zdz2101 zdz2101 linked a pull request May 1, 2023 that will close this issue
Closes #1797 deprecate derive_var_last_* functions #1828
Merged
14 tasks
zdz2101 pushed a commit that referenced this issue May 1, 2023
chore: #1797 forgot a function to deprecate
4d5bcb2
zdz2101 pushed a commit that referenced this issue May 8, 2023
chore: #1797 address merge conflicts
bb4b312 
Merge branch 'devel' into 1797_deprecate_derive_var_last_dose@devel

# Conflicts:
#	man/derive_var_confirmation_flag.Rd
#	man/derive_var_disposition_status.Rd
#	man/derive_var_extreme_flag.Rd
#	man/derive_var_joined_exist_flag.Rd
#	man/derive_var_last_dose_amt.Rd
#	man/derive_var_last_dose_date.Rd
#	man/derive_var_last_dose_grp.Rd
#	man/derive_var_merged_cat.Rd
#	man/derive_var_merged_character.Rd
#	man/derive_var_merged_exist_flag.Rd
#	man/derive_var_merged_summary.Rd
#	man/derive_var_obs_number.Rd
#	man/derive_var_relative_flag.Rd
#	man/derive_var_worst_flag.Rd
#	man/derive_vars_disposition_reason.Rd
#	man/derive_vars_joined.Rd
#	man/derive_vars_last_dose.Rd
#	man/derive_vars_merged.Rd
#	man/derive_vars_merged_lookup.Rd
#	man/derive_vars_transposed.Rd
#	man/format_eoxxstt_default.Rd
#	man/format_reason_default.Rd
#	man/get_summary_records.Rd
@bms63 bms63 added this to the v0.11 milestone May 9, 2023
@zdz2101 zdz2101 moved this from In Progress to In Review in admiral (sdtm/adam, dev, ci, template, core) May 12, 2023
zdz2101 pushed a commit that referenced this issue May 15, 2023
docs: #1797 get roxygen up to date
38ff23b
zdz2101 pushed a commit that referenced this issue May 19, 2023
feat: #1797 crude solution
b9c9459
zdz2101 pushed a commit that referenced this issue May 22, 2023
feat: #1797 deprecation mostly done, couple tests need tweaks
b5325ba
zdz2101 pushed a commit that referenced this issue May 22, 2023
test: #1797 address some problematic tests
5adcd7a
zdz2101 pushed a commit that referenced this issue May 22, 2023
test: #1797 new_vars not quite the same between functions
923636a
zdz2101 pushed a commit that referenced this issue May 23, 2023
docs: #1797 cleanup mistake in roxygen
4f91775
zdz2101 pushed a commit that referenced this issue May 24, 2023
chore: #1797 address styler
efbda3c
zdz2101 pushed a commit that referenced this issue May 24, 2023
test: #1797 how to test the double warning
c5d7ea1
zdz2101 pushed a commit that referenced this issue May 31, 2023
fix: #1797 address merge conflict
5234fd3 
Merge branch 'devel' into 1797_deprecate_derive_var_last_dose@devel

# Conflicts:
#	R/derive_var_last_dose_amt.R
#	man/derive_var_last_dose_amt.Rd
zdz2101 pushed a commit that referenced this issue May 31, 2023
docs: #1797 remove exmaples per prog strat
3277f23
zdz2101 pushed a commit that referenced this issue May 31, 2023
fix: #1797 swap var_last_dose_date with joined in ad_adae
fd6bcdf
zdz2101 pushed a commit that referenced this issue May 31, 2023
fix: #1797 remove reference to derive_vars_last_dose()
ca2b5d4
zdz2101 pushed a commit that referenced this issue May 31, 2023
docs: #1797 adopt feedback on comments of templates
1bf61e5
zdz2101 added a commit that referenced this issue May 31, 2023
@zdz2101
Merge pull request #1828 from pharmaverse/1797_deprecate_derive_var_l…
51b331e 
…ast_dose@devel

Closes #1797 deprecate derive_var_last_* functions
@bms63 bms63 closed this as completed in 7a61bd3 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdz2101 zdz2101

Labels
enhancement New feature or request programming
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
3 participants
@bms63 @zdz2101 @bundfussr