Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the scope of release 0.11.0 #1818

Closed
sadchla-codes opened this issue Mar 10, 2023 · 8 comments
Closed

Define the scope of release 0.11.0 #1818

sadchla-codes opened this issue Mar 10, 2023 · 8 comments

Comments

@sadchla-codes
Copy link
Collaborator

sadchla-codes commented Mar 10, 2023

Background Information

A list of features that would be part of the next release in June 2023

Priority issues thus far with none assigned to them
Documentation: Use study data examples in convert_blanks_to_na() #1709
Feature Request: Deprecate derive_var*_last_dose*() #1797
restrict_derivation() expects the derivation in the global #1765
Failing CI check - rework derive_var_extreme_flag example #1780
Review Programs, vignettes and templates for deprecation #1747

Others to target for release:
Implement filter_exist() and filter_not_exist() #1699
Replacing admiral.test calls in the function examples #1752
Adding an RStudio style cheatsheet #1529

Definition of Done

List of desired features/ updates are under priority should be addressed

Timeline: A new release will occur in early June 2022 (release Q2-2023).
Theme: think overall theme should be around striving for more stability and consistency across our functions and documentation.

@bms63
Copy link
Collaborator

bms63 commented Mar 10, 2023

Thanks for setting this up @sadchla-codes ! @pharmaverse/admiral lets start the planning for release Q2-2023! Please put in your thoughts, concerns.

I think overall theme should be around striving for more stability and consistency across our functions and documentation.

@esimms999-gsk
Copy link
Contributor

I would like to upgrade the development tools we use. For example, we have lintr 2.0.1 in the renv.lock for admiral, admiraldev, admiral.test and the latest version of lintr is 3.0.2, which catches some additional things. Same with styler with all three renv.lock specifying v 1.8.0 and latest version is 1.9.1, which catches additional things. These two have been raised in Issues #1799 and #1798.

Perhaps there are other development tools we could upgrade?

@bms63
Copy link
Collaborator

bms63 commented Mar 10, 2023

I would like to upgrade the development tools we use. For example, we have lintr 2.0.1 in the renv.lock for admiral, admiraldev, admiral.test and the latest version of lintr is 3.0.2, which catches some additional things. Same with styler with all three renv.lock specifying v 1.8.0 and latest version is 1.9.1, which catches additional things. These two have been raised in Issues #1799 and #1798.

Perhaps there are other development tools we could upgrade?

I believe that @galachad is a few steps ahead of you, Eric, with his propagation #1704

@rossfarrugia
Copy link
Collaborator

@bundfussr can you add the next release tag for all those clean up issues you had added as a result of our Q1 talks with Ben and Thomas on making the package more consistent?

@bundfussr
Copy link
Collaborator

@bundfussr can you add the next release tag for all those clean up issues you had added as a result of our Q1 talks with Ben and Thomas on making the package more consistent?

@rossfarrugia , done

@bundfussr
Copy link
Collaborator

I think we should implement pharmaverse/admiraldev#36 to reduce the time we spend on deprecation.

@jeffreyad
Copy link
Collaborator

I would like to add ADPPK template #1772 #1657 and update PK vignette to reference this

@bms63
Copy link
Collaborator

bms63 commented Apr 10, 2023

Scope is pretty well-defined for this release - going to close out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants