Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T10839 many to many relationships #14086

Merged
merged 5 commits into from
May 17, 2019
Merged

T10839 many to many relationships #14086

merged 5 commits into from
May 17, 2019

Conversation

niden
Copy link
Member

@niden niden commented May 17, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Models manager getRelations() now returns the many to many relationships

Thanks

@niden
Copy link
Member Author

niden commented May 17, 2019

cc @sergeyklay

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #14086 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14086      +/-   ##
==========================================
- Coverage   71.32%   71.31%   -0.01%     
==========================================
  Files         479      479              
  Lines       94032    94042      +10     
==========================================
  Hits        67066    67066              
- Misses      26966    26976      +10
Impacted Files Coverage Δ
ext/phalcon/mvc/model/manager.zep.c 64.56% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 546909e...d9759ad. Read the comment docs.

sergeyklay
sergeyklay previously approved these changes May 17, 2019
@niden niden merged commit d2af542 into phalcon:4.0.x May 17, 2019
@niden niden deleted the T10839-many-to-many-relationships branch May 19, 2019 02:59
@niden niden added the 4.0 label Dec 2, 2019
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants