ModelsManager->getRelations doesn't return the many through relations

[thxer]

I think it's missing from phalcon/mvc/model/manager.zep getRelations function.

[thxer]

<?php

$di = new Phalcon\DI();

$di->set(
    'db',
    new Phalcon\Db\Adapter\Pdo\Sqlite(
        array(
            "dbname" => "sample.db"
        )
    )
);

$di->set('modelsManager', new Phalcon\Mvc\Model\Manager());

// Use the memory meta-data adapter or other
$di->set('modelsMetadata', new Phalcon\Mvc\Model\Metadata\Memory());

class Event extends \Phalcon\Mvc\Model{

    protected $id;

    protected $user_id;

    protected $text;

    public function initialize(){
        $this->belongsTo("user_id", "User", "id", ["alias"=>"user"]);
    }

}

class User extends \Phalcon\Mvc\Model{

    protected $id;

    protected $name;

    public function initialize(){
        $this->hasManyToMany("id", "UserGroup", "user_id", "group_id", "Group", "id", ["alias"=>"groups"]);
        $this->hasMany("id", "Events", "user_id", ["alias"=>"events"]);
    }

}

class UserGroup extends \Phalcon\Mvc\Model{

    protected $group_id;

    protected $user_id;

}

class Group extends \Phalcon\Mvc\Model{

    protected $id;

    protected $name;

    public function initialize(){
        $this->hasManyToMany("id", "UserGroup", "group_id", "user_id", "User", "id", ["alias"=>"users"]);
    }
}

// Result
var_dump((new User)->getModelsManager()->getRelations("User"));

// Many to many
var_dump((new User)->getModelsManager()->getHasManyToMany((new User)));

// Expected result for getRelations()
var_dump(array_merge((new User)->getModelsManager()->getRelations("User"), (new User)->getModelsManager()->getHasManyToMany((new User))));

Output

array(1) {
  [0]=>
  object(Phalcon\Mvc\Model\Relation)#12 (8) {
    ["_type":protected]=>
    int(2)
    ["_referencedModel":protected]=>
    string(6) "Events"
    ["_fields":protected]=>
    string(2) "id"
    ["_referencedFields":protected]=>
    string(7) "user_id"
    ["_intermediateModel":protected]=>
    NULL
    ["_intermediateFields":protected]=>
    NULL
    ["_intermediateReferencedFields":protected]=>
    NULL
    ["_options":protected]=>
    array(1) {
      ["alias"]=>
      string(6) "events"
    }
  }
}
array(1) {
  [0]=>
  object(Phalcon\Mvc\Model\Relation)#11 (8) {
    ["_type":protected]=>
    int(4)
    ["_referencedModel":protected]=>
    string(5) "Group"
    ["_fields":protected]=>
    string(2) "id"
    ["_referencedFields":protected]=>
    string(2) "id"
    ["_intermediateModel":protected]=>
    string(9) "UserGroup"
    ["_intermediateFields":protected]=>
    string(7) "user_id"
    ["_intermediateReferencedFields":protected]=>
    string(8) "group_id"
    ["_options":protected]=>
    array(1) {
      ["alias"]=>
      string(6) "groups"
    }
  }
}
array(2) {
  [0]=>
  object(Phalcon\Mvc\Model\Relation)#12 (8) {
    ["_type":protected]=>
    int(2)
    ["_referencedModel":protected]=>
    string(6) "Events"
    ["_fields":protected]=>
    string(2) "id"
    ["_referencedFields":protected]=>
    string(7) "user_id"
    ["_intermediateModel":protected]=>
    NULL
    ["_intermediateFields":protected]=>
    NULL
    ["_intermediateReferencedFields":protected]=>
    NULL
    ["_options":protected]=>
    array(1) {
      ["alias"]=>
      string(6) "events"
    }
  }
  [1]=>
  object(Phalcon\Mvc\Model\Relation)#11 (8) {
    ["_type":protected]=>
    int(4)
    ["_referencedModel":protected]=>
    string(5) "Group"
    ["_fields":protected]=>
    string(2) "id"
    ["_referencedFields":protected]=>
    string(2) "id"
    ["_intermediateModel":protected]=>
    string(9) "UserGroup"
    ["_intermediateFields":protected]=>
    string(7) "user_id"
    ["_intermediateReferencedFields":protected]=>
    string(8) "group_id"
    ["_options":protected]=>
    array(1) {
      ["alias"]=>
      string(6) "groups"
    }
  }
}

[thxer]

Any info?

[sergeyklay]

I'll try to sort out

[idevelop4you]

Hello, any info on this? It seems still present.

[idevelop4you]

This issue is open from more than 2 years but seems that no-one is interested on it.

It could be solved by adding this piece of code in the getRelations method:

/**
  * Get has-many-to-many relations
 */
if fetch relations, this->_hasManyToManySingle[entityName] {
	for relation in relations {
		let allRelations[] = relation;
	}
}

Meanwhile I made it working by extending the original ModelsManager and overriding the getRelations method in order to add the many-to-many relation to the returned list:

<?php

class Manager extends ModelManager {  
    public function getRelations($modelName) {  
       $relations = parent::getRelations($modelName);  
       $entity = strtolower($modelName);  
       if(array_key_exists($entity, $this->_hasManyToManySingle)){  
           foreach ($this->_hasManyToManySingle[$entity] as $relation){  
               $relations[] = $relation;  
           }  
       }  
       return $relations;  
    }  
}  

[robinbertram]

I just bumped into this as well. Your workaround works fine @idevelop4you. But obviously it would be nice if this was fixed.

Ping: @sergeyklay

[niden]

Resolved in #14086