Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.x: adding missing method isSent to interface ResponseInterface #13836

Merged
merged 2 commits into from
Feb 18, 2019

Conversation

Idrinth
Copy link
Contributor

@Idrinth Idrinth commented Feb 18, 2019

Hello!

  • Type: bug fix
  • Link to issue: -

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

This is a followup to #13821, adding the missing method to the interface. Compare #13821 (comment)

@Idrinth Idrinth marked this pull request as ready for review February 18, 2019 12:38
@Idrinth Idrinth changed the title adding missing method isSent to interface ResponseInterface 4.0.x: adding missing method isSent to interface ResponseInterface Feb 18, 2019
sergeyklay
sergeyklay previously approved these changes Feb 18, 2019
Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you update change log?

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #13836 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #13836   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files         448      448           
  Lines       89344    89344           
=======================================
  Hits        59134    59134           
  Misses      30210    30210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4cd29d...9d301e4. Read the comment docs.

@niden niden merged commit b19d84a into phalcon:4.0.x Feb 18, 2019
@niden
Copy link
Member

niden commented Feb 18, 2019

Thank you @Idrinth

@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Dec 2, 2019
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants