preventing call to undefined method isSent #13821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeckerson
reviewed
Feb 12, 2019
|
I'm not sure how |
|
@Idrinth Thank you for your contribution! We are no longer accepting pull requests to |
|
still an issue in master and 4.0.x, but with 4 being breaking it might be a better choice to add the missing method to the interface, wouldn't it @CameronHall ? |
|
Absolutely @Idrinth! |
3 tasks
|
replaced with #13836 to solve issue in 4.0.x |
niden
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Currently isSent is only implemented by
Responseand not part of theResponseInterface. Therefore calling it on instances of the interfaces is not a reasonable solution.Adjusting the interface would break backwards compatibility, so adding the check seems like the more sensible option.