Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.x] [BUG] fixing bug and other enchantments #10217

Merged
merged 4 commits into from
May 1, 2015

Conversation

KorsaR-ZN
Copy link
Contributor

fixing bug (prev PR #10166):

$builder = $model->getModelsManager()->createBuilder()
->columns($columns)
   ->addFrom('CartItems', 's')
   ->where('s.cart_id="6086"')
   ->groupBy('s.product_id');

echo $readConnection->getDialect()->select($q->getQuery()->parse());

Result:

SELECT ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, `` FROM `cart_items` AS `s` WHERE `s`.`cart_id` = '6086' GROUP BY `s`.`product_id`

And also fix for #10160, #10135

@KorsaR-ZN
Copy link
Contributor Author

@andresgutierrez Build failed after commit 5e33a16
see, build passed - https://travis-ci.org/KorsaR-ZN/phalcon-core/builds/60859518

andresgutierrez added a commit that referenced this pull request May 1, 2015
[2.0.x] [BUG] fixing bug and other enchantments
@andresgutierrez andresgutierrez merged commit 258bf0d into phalcon:2.0.x May 1, 2015
@andresgutierrez
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants