Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.x] [BUG] fixing bug and other enchantments #10166

Closed
wants to merge 4 commits into from

Conversation

KorsaR-ZN
Copy link
Contributor

fixing bug (prev PR #10144):

$builder = $model->getModelsManager()->createBuilder()
->columns($columns)
   ->addFrom('CartItems', 's')
   ->where('s.cart_id="6086"')
   ->groupBy('s.product_id');

echo $readConnection->getDialect()->select($q->getQuery()->parse());

Result:

SELECT ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, ``, `` FROM `cart_items` AS `s` WHERE `s`.`cart_id` = '6086' GROUP BY `s`.`product_id`

@KorsaR-ZN KorsaR-ZN force-pushed the patch-11 branch 2 times, most recently from f235d78 to a992411 Compare April 25, 2015 03:10
@KorsaR-ZN
Copy link
Contributor Author

fix for #10160, #10135

@andresgutierrez
Copy link
Contributor

Could you please leave method signatures as they were? Change them could break existing applications

@KorsaR-ZN
Copy link
Contributor Author

@andresgutierrez I will send other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants