Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sharding rules #510

Merged
merged 35 commits into from
Feb 21, 2024
Merged

Remove sharding rules #510

merged 35 commits into from
Feb 21, 2024

Conversation

EinKrebs
Copy link
Collaborator

No description provided.

@EinKrebs
Removed sharding rule usage from data motions & changed mover's API
60f9aa5
@EinKrebs
Fixed lint
434d7d2
@EinKrebs
Refactored mover
8e3b5b2
@EinKrebs
Removed unused parameter from MoveKeys
85616ea
@EinKrebs
Removed ShardingRuleMgr from EntityMgr
00f136b
@EinKrebs
Removed ShardingRuleMgr
116dd63
@EinKrebs
Added test for sharding rules removal
c1c0aca
@EinKrebs
Removed show_sharding_rules regression test
f057830
@EinKrebs
Removed sharding rules from add regression test
87b8a47
@EinKrebs
Removed sharding rules from delete_distribution regression test
b846afe
@EinKrebs
Removed sharding rules from drop regression test
123ea4b
@EinKrebs
Removed sharding rules from hash regression test
a4b81f5
@EinKrebs
Removed sharding rules from show_sistributions regression test
8c987c1
@EinKrebs
Removed sharding rules from show_key_ranges regression test
7df8277
@EinKrebs
Removed sharding rules from console regression tests teardown
e7aedf7
@EinKrebs
FIXUP_INTO sharding_rules
e710eeb
@EinKrebs
Removed sharding rules from router regress tests
d0568cb
@EinKrebs
Changed CheckTableIsRoutable logic
e43e252
@EinKrebs
Remove MatchShardingRules function
9ede5dc
@EinKrebs
Removed sharding rules from feature tests
0076044
@EinKrebs
Fixed regress tests
040fb3e
@EinKrebs
Fixed unittests
0fc712d
@EinKrebs
Added TODOs
7f48d22
@EinKrebs
Fixes, my fixes
9c6c466
Denchick
Denchick requested changes Feb 20, 2024
View reviewed changes
cmd/mover/main.go Outdated Show resolved Hide resolved
coordinator/provider/coordinator.go Show resolved Hide resolved
coordinator/provider/sharding_rules.go Outdated Show resolved Hide resolved
pkg/meta/meta.go Outdated Show resolved Hide resolved
pkg/meta/meta.go Show resolved Hide resolved
router/qrouter/proxy_routing.go Show resolved Hide resolved
router/qrouter/proxy_routing_test.go Outdated Show resolved Hide resolved
test/feature/features/coordinator.feature Show resolved Hide resolved
test/regress/tests/router/expected/joins.out Outdated Show resolved Hide resolved
test/feature/features/memqdb.feature Show resolved Hide resolved
Denchick
Denchick reviewed Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@Denchick Denchick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed to do in next PRs:

  • Drop *ShardingRules in QDB
  • Add the test "it is not possible to attach the same table to dataspace"
  • Add test "restore relations from memqdb file" here
  • Relations List via SQL #512

@Denchick Denchick merged commit d4827ee into master Feb 21, 2024
18 of 20 checks passed
@EinKrebs EinKrebs deleted the remove-sharding-rules branch February 21, 2024 13:25
@EinKrebs EinKrebs mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Denchick Denchick Denchick approved these changes

@reshke reshke reshke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EinKrebs @Denchick @reshke