Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use sharding rule for table creation check. Also drop them from unit and regress #496

Closed
wants to merge 8 commits into from

Conversation

reshke
Copy link
Collaborator

@reshke reshke commented Feb 13, 2024

db1=# create table tt2(id int);
ERROR:  client proccessing error: error processing query 'create table tt2(id int);': create table stmt ignored: no distributions for this relation found, tx status IDLE

@reshke reshke enabled auto-merge (squash) February 13, 2024 13:11
@Denchick
Copy link
Collaborator

no distributions for this relation found, tx status IDLE

wait, maybe error or something else? Seem like there is no reasons to keep client

@reshke reshke changed the title Check distribution on create table statement Drop sharding rule a littke Feb 16, 2024
@reshke reshke changed the title Drop sharding rule a littke Drop sharding rule a little Feb 16, 2024
@reshke reshke changed the title Drop sharding rule a little Do not use sharding rule for table creation check. Also drop them from unit and regress Feb 16, 2024
Copy link
Collaborator

@Denchick Denchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost all regress tests failed

(using postmaster on regress_router, port 6432)
============== running regression test queries        ==============
test shard_routing                ... FAILED       44 ms
test mixed_routing                ... FAILED       28 ms
test copy_routing                 ... FAILED       15 ms
test joins                        ... FAILED       19 ms
test target_session_attrs         ... FAILED       14 ms
test transactions                 ... ok           17 ms
test with_tables                  ... FAILED       25 ms
test single_shard_joins           ... FAILED       15 ms
test multishard                   ... ok           19 ms
test error                        ... FAILED       20 ms
test begin                        ... FAILED       25 ms
test switch_distribution          ... FAILED       13 ms
test alter_distribution           ... FAILED       26 ms

@EinKrebs
Copy link
Collaborator

Obsolete due to #510, consider colsing this PR

@Denchick Denchick closed this Sep 19, 2024
auto-merge was automatically disabled September 19, 2024 09:26

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants