-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use sharding rule for table creation check. Also drop them from unit and regress #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
reshke
commented
Feb 13, 2024
•
edited
Loading
edited
wait, maybe error or something else? Seem like there is no reasons to keep client |
reshke
changed the title
Check distribution on create table statement
Drop sharding rule a littke
Feb 16, 2024
reshke
changed the title
Drop sharding rule a little
Do not use sharding rule for table creation check. Also drop them from unit and regress
Feb 16, 2024
Denchick
requested changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost all regress tests failed
(using postmaster on regress_router, port 6432)
============== running regression test queries ==============
test shard_routing ... FAILED 44 ms
test mixed_routing ... FAILED 28 ms
test copy_routing ... FAILED 15 ms
test joins ... FAILED 19 ms
test target_session_attrs ... FAILED 14 ms
test transactions ... ok 17 ms
test with_tables ... FAILED 25 ms
test single_shard_joins ... FAILED 15 ms
test multishard ... ok 19 ms
test error ... FAILED 20 ms
test begin ... FAILED 25 ms
test switch_distribution ... FAILED 13 ms
test alter_distribution ... FAILED 26 ms
Obsolete due to #510, consider colsing this PR |
auto-merge was automatically disabled
September 19, 2024 09:26
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.