Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for super() usage on "old style class" ZipFile #546

Merged
merged 1 commit into from
Sep 6, 2018

Commits on Aug 29, 2018

  1. Fix for super() usage on "old style class" ZipFile

    I was experienceing an error of "TypeError: must be type, not classobj"
    on the line using `super()._extract_member()` below.
    This error appears to be due to the `zipfile.ZipFile` class never inheriting from
    `object` which is a requirement since py2.2 (2001).
    
    Since the use of `super()` in `PermPreservingZipFile()` depends on
    `object` being somewhere in the inheritance tree, I am including it in
    the class definition of `PermPreservingZipFile()`. My testing of this patch
    locally has proven to solve the "TypeError" I was seeing.
    cbrinker committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    94cf4a0 View commit details
    Browse the repository at this point in the history