Fix for super() usage on "old style class" ZipFile #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was experienceing an error of "TypeError: must be type, not classobj" on the line using `super()._extract_member()` below. This error appears to be due to the `zipfile.ZipFile` class never inheriting from `object` which is a requirement since py2.2 (2001). Since the use of `super()` in `PermPreservingZipFile()` depends on `object` being somewhere in the inheritance tree, I am including it in the class definition of `PermPreservingZipFile()`. My testing of this patch locally has proven to solve the "TypeError" I was seeing.
|
CI is continuing to fail on 1 shard despite me re-running it a few times. It does not likely to be related to the change, but one thing that seems a bit off is multiple-inheriting from object instead of using old-style super to go along with the old-style baseclass. IE: result = PermPreservingZipFile._extract_member(self, member, targetpath, pwd) |
|
Alrighty - got this green with another shard restart :/ Thanks @cbrinker ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing an error of "TypeError: must be type, not classobj"
on the line using
super()._extract_member()below.This error appears to be due to the
zipfile.ZipFileclass never inheriting fromobjectwhich is a requirement since py2.2 (2001).Since the use of
super()inPermPreservingZipFile()depends onobjectbeing somewhere in the inheritance tree, I am including it inthe class definition of
PermPreservingZipFile(). My testing of this patchlocally has proven to solve the "TypeError" I was seeing.