Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup bootstrap dependencies before handoff. #542

Merged
merged 4 commits into from
Aug 29, 2018
Merged

Cleanup bootstrap dependencies before handoff. #542

merged 4 commits into from
Aug 29, 2018

Commits on Aug 28, 2018

  1. Cleanup bootstrap dependencies before handoff. 

    Previously we polluted the third party import space with any third
party dependencies of the pex bootstrap code (currently a subset of
setuptools). We now unimport all third_party code in bootstrap and
place bootstrap at the end of `sys.path` before handing off to user
code to allow their custom versions of overlapping third party code
to be imported.

Added a failing test that the demoted_bootstrap code now fixes.

Fixes pex-tool#437.
    @jsirois
    jsirois committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    c7ee8f4 View commit details
    Browse the repository at this point in the history

  2. Fixup execute_pkg_resources and add more tests.

    @jsirois
    jsirois committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    3462a89 View commit details
    Browse the repository at this point in the history

  3. Remove un-needed contextmanagers. 

    We had a few of this operating in the leadup to hand-off to user
code.
    @jsirois
    jsirois committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    a972cb2 View commit details
    Browse the repository at this point in the history

  4. Fixup trailing blank line.

    @jsirois
    jsirois committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    c320d10 View commit details
    Browse the repository at this point in the history