-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pex shadows pkg_resources, which can break newer versions of setuptools #437
Labels
Comments
We probably need to vendor our |
Or... delegate to the final picked runner in a contextmanager that removes .bootstrap from the sys.path and the re-adds it on exit so pex exit handlers - if any can run - which is the POC above. I'll try this first. |
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Aug 20, 2018
Previously we polluted the third party import space with any third party dependencies of the pex bootstrap code (currently a subset of setuptools). We now unimport all third_party code in bootstrap and place bootstrap at the end of `sys.path` before handing off to user code to allow their custom versions of overlapping third party code to be imported. Added a failing test that the demoted_bootstrap code now fixes. Fixes pex-tool#437.
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Aug 24, 2018
Previously we polluted the third party import space with any third party dependencies of the pex bootstrap code (currently a subset of setuptools). We now unimport all third_party code in bootstrap and place bootstrap at the end of `sys.path` before handing off to user code to allow their custom versions of overlapping third party code to be imported. Added a failing test that the demoted_bootstrap code now fixes. Fixes pex-tool#437.
Closed
jsirois
added a commit
to jsirois/pex
that referenced
this issue
Aug 28, 2018
Previously we polluted the third party import space with any third party dependencies of the pex bootstrap code (currently a subset of setuptools). We now unimport all third_party code in bootstrap and place bootstrap at the end of `sys.path` before handing off to user code to allow their custom versions of overlapping third party code to be imported. Added a failing test that the demoted_bootstrap code now fixes. Fixes pex-tool#437.
jsirois
added a commit
that referenced
this issue
Aug 29, 2018
* Cleanup bootstrap dependencies before handoff. Previously we polluted the third party import space with any third party dependencies of the pex bootstrap code (currently a subset of setuptools). We now unimport all third_party code in bootstrap and place bootstrap at the end of `sys.path` before handing off to user code to allow their custom versions of overlapping third party code to be imported. Added a failing test that the demoted_bootstrap code now fixes. Fixes #437.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
with a version of setuptools inside pex's allowed range:
with a newer one:
because:
poc:
The text was updated successfully, but these errors were encountered: