Complete support for PEX Python interpreter mode. #1748
Conversation
Apply @BrandonTheBuilder's work in pex-tool#1746 to the `--venv` case and flesh out complete support for Python interpreter emulation by adding `.` to the `sys.path` when running as an interpreter and handling interpreter execution of directories. Fixes pex-tool#1745
| # N.B.: This should never happen. | ||
| return "Unable to resolve PEX __main__ module file: {}".format(main) |
There was a problem hiding this comment.
How about raising AssertionError?
There was a problem hiding this comment.
As the tests show, those can be turned off. This gives a clean non-zero exit with a non-backtrace mess message and is in line with all other exits here. What are you seeing as the advantage of an assertion over this? Collapsing a comment?
There was a problem hiding this comment.
That usually when you say "this shouldn't happen", using an assert is the way to ensure that doesn't happen. Sg though
There was a problem hiding this comment.
Well, an assert doesn't "ensure it doesn't happen" as the -O tests show, I think you must mean it expresses intent better, or at least more concisely. That I don't disagree with, but will leave as Loren established it.
Apply @BrandonTheBuilder's work in #1746 to the
--venvcase and fleshout complete support for Python interpreter emulation by adding
.tothe
sys.pathwhen running as an interpreter and handling interpreterexecution of directories.
Fixes #1745