Re-exec with interpreter-options when set. (#1745) #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonTheBuilder
force-pushed
the
interpreter-options
branch
from
9b1691a to
8e34f12
Compare
jsirois
approved these changes
May 3, 2022
| Restart the process passing the given options to the python interpreter | ||
| """ | ||
| # Find the pex bootstrap location | ||
| # We expect this environment variable to be set by __main__.py |
There was a problem hiding this comment.
This comment is a bit stale and needs adjustment.
| ) | ||
| os.execv(interpreter, cmdline) | ||
| else: | ||
| return "Unable to resolve pex path" |
There was a problem hiding this comment.
This should be impossible; so its not very important except for the code reader, but it would be spot on if it said "Unable to resolve installed pex path".
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
May 4, 2022
Apply @BrandonTheBuilder's work in pex-tool#1746 to the `--venv` case and flesh out complete support for Python interpreter emulation by adding `.` to the `sys.path` when running as an interpreter and handling interpreter execution of directories. Fixes pex-tool#1745
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
May 4, 2022
Apply @BrandonTheBuilder's work in pex-tool#1746 to the `--venv` case and flesh out complete support for Python interpreter emulation by adding `.` to the `sys.path` when running as an interpreter and handling interpreter execution of directories. Fixes pex-tool#1745
jsirois
added a commit
that referenced
this pull request
May 4, 2022
Apply @BrandonTheBuilder's work in #1746 to the `--venv` case and flesh out complete support for Python interpreter emulation by adding `.` to the `sys.path` when running as an interpreter and handling interpreter execution of directories. Fixes #1745
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse options args for interpreter options. If they are present re-exec passing the proper options to the interpreter. If they are not present run the code directly.