Skip to content

Commit

Permalink
ci(github-workflows): launch CI on PR & push for all branches
Browse files Browse the repository at this point in the history
Before this change the only time the CI would get executed was when
a pull request was submitted against the $DEFAULT branch. After this
the CI will run for every commit and pull request that is issued against
the any branches.
The specific reason for this change is that we introduced a new branch
called dev which can be used to provide early access to pending changes
that may or may not be stuck in the review queue for longer periods of
time. Of course there's an additional overhead in maintaining this
dev branch by way of cherry picking and rebasing, but this is minor
compared to the positive effects it can bring to the community.

Fixes hyperledger-cacti#434

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
  • Loading branch information
petermetz committed Dec 17, 2020
1 parent cff3b23 commit c6d4e41
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Cactus CI Github Workflow

# Triggers the workflow on pull request events
on: [pull_request]
# Triggers the workflow on push or pull request events
on: [push, pull_request]

jobs:
build:
Expand Down

0 comments on commit c6d4e41

Please sign in to comment.