ci(github-workflows): launch CI on PR & push for all branches #434

petermetz · 2020-12-17T20:54:53Z

Description

Currently the dev branch does not have CI running on it, but we could use the verification it provides when the tests are passing (or the notification when they are not).

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton

The text was updated successfully, but these errors were encountered:

Before this change the only time the CI would get executed was when a pull request was submitted against the $DEFAULT branch. After this the CI will run for every commit and pull request that is issued against the any branches. The specific reason for this change is that we introduced a new branch called dev which can be used to provide early access to pending changes that may or may not be stuck in the review queue for longer periods of time. Of course there's an additional overhead in maintaining this dev branch by way of cherry picking and rebasing, but this is minor compared to the positive effects it can bring to the community. Fixes hyperledger-cacti#434 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Before this change the only time the CI would get executed was when a pull request was submitted against the $DEFAULT branch. After this the CI will run for every commit and pull request that is issued against the any branches. The specific reason for this change is that we introduced a new branch called dev which can be used to provide early access to pending changes that may or may not be stuck in the review queue for longer periods of time. Of course there's an additional overhead in maintaining this dev branch by way of cherry picking and rebasing, but this is minor compared to the positive effects it can bring to the community. Fixes #434 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> (cherry picked from commit c6d4e41)

Before this change the only time the CI would get executed was when a pull request was submitted against the $DEFAULT branch. After this the CI will run for every commit and pull request that is issued against the any branches. The specific reason for this change is that we introduced a new branch called dev which can be used to provide early access to pending changes that may or may not be stuck in the review queue for longer periods of time. Of course there's an additional overhead in maintaining this dev branch by way of cherry picking and rebasing, but this is minor compared to the positive effects it can bring to the community. Fixes hyperledger-cacti#434 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>

Before this change the only time the CI would get executed was when a pull request was submitted against the $DEFAULT branch. After this the CI will run for every commit and pull request that is issued against the any branches. The specific reason for this change is that we introduced a new branch called dev which can be used to provide early access to pending changes that may or may not be stuck in the review queue for longer periods of time. Of course there's an additional overhead in maintaining this dev branch by way of cherry picking and rebasing, but this is minor compared to the positive effects it can bring to the community. Fixes #434 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> (cherry picked from commit c6d4e41)

Before this change the only time the CI would get executed was when a pull request was submitted against the $DEFAULT branch. After this the CI will run for every commit and pull request that is issued against the any branches. The specific reason for this change is that we introduced a new branch called dev which can be used to provide early access to pending changes that may or may not be stuck in the review queue for longer periods of time. Of course there's an additional overhead in maintaining this dev branch by way of cherry picking and rebasing, but this is minor compared to the positive effects it can bring to the community. Fixes hyperledger-cacti#434 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> (cherry picked from commit c6d4e41)

Before this change the only time the CI would get executed was when a pull request was submitted against the $DEFAULT branch. After this the CI will run for every commit and pull request that is issued against the any branches. The specific reason for this change is that we introduced a new branch called dev which can be used to provide early access to pending changes that may or may not be stuck in the review queue for longer periods of time. Of course there's an additional overhead in maintaining this dev branch by way of cherry picking and rebasing, but this is minor compared to the positive effects it can bring to the community. Fixes #434 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> (cherry picked from commit c6d4e41)

Before this change the only time the CI would get executed was when a pull request was submitted against the $DEFAULT branch. After this the CI will run for every commit and pull request that is issued against the any branches. The specific reason for this change is that we introduced a new branch called dev which can be used to provide early access to pending changes that may or may not be stuck in the review queue for longer periods of time. Of course there's an additional overhead in maintaining this dev branch by way of cherry picking and rebasing, but this is minor compared to the positive effects it can bring to the community. Fixes hyperledger-cacti#434 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> (cherry picked from commit c6d4e41)

Before this change the only time the CI would get executed was when a pull request was submitted against the $DEFAULT branch. After this the CI will run for every commit and pull request that is issued against the any branches. The specific reason for this change is that we introduced a new branch called dev which can be used to provide early access to pending changes that may or may not be stuck in the review queue for longer periods of time. Of course there's an additional overhead in maintaining this dev branch by way of cherry picking and rebasing, but this is minor compared to the positive effects it can bring to the community. Fixes #434 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> (cherry picked from commit c6d4e41)

Before this change the only time the CI would get executed was when a pull request was submitted against the $DEFAULT branch. After this the CI will run for every commit and pull request that is issued against the any branches. The specific reason for this change is that we introduced a new branch called dev which can be used to provide early access to pending changes that may or may not be stuck in the review queue for longer periods of time. Of course there's an additional overhead in maintaining this dev branch by way of cherry picking and rebasing, but this is minor compared to the positive effects it can bring to the community. Fixes hyperledger-cacti#434 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> (cherry picked from commit c6d4e41)

Before this change the only time the CI would get executed was when a pull request was submitted against the $DEFAULT branch. After this the CI will run for every commit and pull request that is issued against the any branches. The specific reason for this change is that we introduced a new branch called dev which can be used to provide early access to pending changes that may or may not be stuck in the review queue for longer periods of time. Of course there's an additional overhead in maintaining this dev branch by way of cherry picking and rebasing, but this is minor compared to the positive effects it can bring to the community. Fixes #434 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> (cherry picked from commit c6d4e41)

- Prototype Pollution in immer hyperledger-cacti#434 hyperledger-cacti#435 - Overflow in prost-types hyperledger-cacti#423 - Dependabot alerts hyperledger-cacti#499 - Dependabot alerts hyperledger-cacti#570 Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>

petermetz added enhancement New feature or request good-first-issue Good for newcomers Developer_Experience Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Dec 17, 2020

petermetz added this to the v0.3.0 milestone Dec 17, 2020

petermetz self-assigned this Dec 17, 2020

petermetz mentioned this issue Dec 17, 2020

ci(github-workflows): launch CI on PR & push for all branches #435

Merged

petermetz modified the milestones: v0.3.0, v0.4.0 Jan 8, 2021

petermetz closed this as completed in #435 Jan 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(github-workflows): launch CI on PR & push for all branches #434

ci(github-workflows): launch CI on PR & push for all branches #434

petermetz commented Dec 17, 2020

ci(github-workflows): launch CI on PR & push for all branches #434

ci(github-workflows): launch CI on PR & push for all branches #434

Comments

petermetz commented Dec 17, 2020

Description