Prod build deployment #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a production version of cuiloa with pd, cometbft, and the indexer.
|
I chose to push the docker-compose file update for review but will toss it if nothing comes of it. |
…llow copying of the required assets for standalone build
There's no longer a "public/" directory to copy between image layers.
I often use a local `.envrc` to customize env vars for connecting a dev env to various external URLs. Tacking on a git-ignore rule to ensure I don't screw up and commit those.
conorsch
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
The Containerfile changes look great! Thanks for the hard work on that. Had to push a tiny fix to unbreak container builds in the new format, then it worked swimmingly for me.
The compose changes are harder for me to review, but I'm not going to block on that: let's land this iterative update on the compose env, and continue to bang it into shape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27 #71
This is a production ready Containerfile that builds Cuiloa for production and optimizes it for packaging as an image. The docker-compose file wasn't updated as planned due to issues with building and running
pdalongsidecometbftand my inability to get them playing nicely with the psql indexer.