Support single quoted keys correctly (#61) #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit (a410399) doesn't work correctly because that must be handled by lexers. parseKey() must not handle escape sequences.
pelletier
reviewed
Nov 7, 2017
| l.next() | ||
| continue | ||
| } else if r == '\n' { | ||
| return l.errorf("keys cannot contain new lines") | ||
| } else if isSpace(r) { | ||
| } else if isSpace(r) || r == ']' { |
| @@ -71,18 +71,14 @@ func (t *Tree) Keys() []string { | |||
| } | |||
|
|
|||
| // Get the value at key in the Tree. | |||
| // Key is a dot-separated path (e.g. a.b.c). | |||
| // Key is a dot-separated path (e.g. a.b.c) without single/double quoted strings | |||
There was a problem hiding this comment.
Missing . at the end of the sentence. Also, do you mind adding a comment about using GetPath if the support for non-bare keys is required?
pelletier
pushed a commit
that referenced
this pull request
Jan 18, 2018
|
merged with 4874e84 |
|
Thanks for merging! Sorry for not responding your comments quickly... |
|
No worries. Thank you for the fix!
--
Thomas Pelletier
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit (a410399) doesn't work correctly because that
must be handled by lexers. parseKey() must not handle escape sequences.