Support single quoted keys (#61) #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR doesn't implement single-quoted keys correctly, then yes, please fix that in this PR. |
|
I've updated the PR to support escape sequence correctly. The logic is pretty similar to lexString(), which should be merged into one function though. |
|
@kzys, use gofmt. |
|
Thanks. Updated the pull request. |
pelletier
pushed a commit
that referenced
this pull request
Oct 21, 2017
|
Merged a410399. Thank you for implementing that! |
pelletier
pushed a commit
that referenced
this pull request
Jan 18, 2018
pelletier
added a commit
that referenced
this pull request
Jan 18, 2018
Patch #193 introduced a regression in the toml-tests examples, but it was never caught because test.sh was exiting with a zero status code, even though the tests failed. This is because of the `|tee` operation when invoking toml-test, without setting the pipefail option, reporting the status code of `tee` instead of `toml-test`.
pelletier
added a commit
that referenced
this pull request
Jan 18, 2018
Patch #193 introduced a regression in the toml-tests examples, but it was never caught because test.sh was exiting with a zero status code, even though the tests failed. This is because of the `|tee` operation when invoking toml-test, without setting the pipefail option, reporting the status code of `tee` instead of `toml-test`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supports single quoted keys as like quoted keys. However both don't support escape sequences correctly.
According to the spec;
Should we fix both of them in this PR?