Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take environment variables from config/environment #7

Open
lukebond opened this issue Mar 18, 2015 · 1 comment
Open

Take environment variables from config/environment #7

lukebond opened this issue Mar 18, 2015 · 1 comment
Labels
enhancement

Comments

@lukebond
Copy link
Contributor

Currently the start script is substituting them in before running the app. If the correct values are in config/environment then they should be used from there.
lukebond added a commit that referenced this issue Mar 18, 2015
@lukebond
Fix envvar substitution
61ac727 
This still isn't ideal. See #7.

Fixes #6
@lukebond lukebond mentioned this issue Mar 18, 2015
Merged
@lukebond
Copy link
Contributor Author

it seems that Ember expects us to do it at ember build time, which doesn't suit us. for now the solution is awfully hacky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukebond