Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment variables not being picked up #6

Closed
lukebond opened this issue Mar 18, 2015 · 2 comments · Fixed by #8
Closed

Environment variables not being picked up #6

lukebond opened this issue Mar 18, 2015 · 2 comments · Fixed by #8

Comments

@lukebond
Copy link
Contributor

Due to filename change, the run script no longer correctly does the substitution. Fix incoming.
lukebond added a commit that referenced this issue Mar 18, 2015
@lukebond
Fix envvar substitution
61ac727 
This still isn't ideal. See #7.

Fixes #6
@lukebond lukebond mentioned this issue Mar 18, 2015
Merged
lukebond added a commit that referenced this issue Mar 18, 2015
@lukebond
Envvar substitution still not right.
aecd1e7 
See #6
@lukebond
Copy link
Contributor Author

The environment variables are being correctly substituted into assets/paz-ember-*.js but they don't appear to be used.

Perhaps something in the refactor has the URLs coming from somewhere else?

@lukebond lukebond reopened this Mar 18, 2015
lukebond added a commit that referenced this issue Mar 19, 2015
@lukebond
Setting url of orchestrator in index.html
c579453 
See #6
@lukebond
Copy link
Contributor Author

Fixed by c579453

But really not nice....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix envvar substitution paz-sh/paz-web
1 participant
@lukebond