FISH-9456 Resource Bundles #6903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
reviewed
Aug 23, 2024
There was a problem hiding this comment.
I think is a bit of a band-aid fix.
It resolves the issue, as LogDomain explicitly looks for LogStrings.properties, but it seems to be at odds with LogFacade which is explicitly looking for LogMessages.properties which is where the actual log messages exist.
It seems the file was renamed in #5579 (and with a follow up #5588) to fix an l10n issue.
This might need unpicking a bit...
|
Jenkins test please |
|
tested on linux ubuntu 20.04, azul jdk 11, maven 3.8.6 |
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Sep 16, 2024
FISH-9456 Resource Bundles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important Info
Blockers
Testing
New tests
Testing Performed
Started the server, created a new instance, closed the server, and then started the server again.
Testing Environment
Maven version: 3.9.6
Java version: 11.0.23, vendor: Eclipse Adoptium
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"
Documentation
Notes for Reviewers