Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-5857 Fix Error Starting Embedded EJB Container #5588

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

Pandrex247
Copy link
Member

Description

TCK tests reveal a recent file change has broken the Embedded EJB Container, specifically in DomainXmlTransformer when it tries to find its logger.

jakarta.ejb.EJBException: Caught unexpected exception trying to create a temporary domain.xml file.
...
Caused by: java.util.MissingResourceException: Can't find com.sun.logging.enterprise.system.container.ejb.LogStrings bundle from

The log file name was changed in a recent PR to fix another error, and so this fixes the new error by having it point to the moved file.

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

Ran ejb30/lite/packaging/ TCK

Testing Environment

WSL, JDK 8

Documentation

N/A

Notes for Reviewers

PR which changed file name here: #5579

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247 Pandrex247 changed the title FISH-5857 Fix Error Started Embedded EJB Container FISH-5857 Fix Error Starting Embedded EJB Container Jan 28, 2022
@Pandrex247
Copy link
Member Author

Jenkins test please

Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pandrex247 Pandrex247 merged commit 00b15b0 into payara:master Jan 31, 2022
@Pandrex247 Pandrex247 deleted the FISH-5857 branch January 31, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants