Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the condition that ignores files in AssembleFilelisting #40

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Remove the condition that ignores files in AssembleFilelisting #40

merged 3 commits into from
Apr 18, 2024

Conversation

kavir1698
Copy link
Collaborator

Fixes #39

@kavir1698 kavir1698 requested a review from a team April 17, 2024 13:02
minottic
minottic reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is such a fundamental check, I would add some tests.

@kavir1698
Copy link
Collaborator Author

kavir1698 commented Apr 17, 2024 •
edited
Loading

since this is such a fundamental check, I would add some tests.

Sure. First, we need to decide how to check on the discovery #41

@minottic
Copy link
Collaborator

can the first test be that it passes that point?

@kavir1698
Add tests
bf668af
@kavir1698
Remove check for owner
5740743 
On windows it is empty, on Linux, it is not.
@kavir1698 kavir1698 requested a review from minottic April 18, 2024 07:52
@kavir1698 kavir1698 merged commit 99d9ba1 into main Apr 18, 2024
3 checks passed
@kavir1698 kavir1698 deleted the ingest_test branch April 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minottic minottic minottic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File enumeration issue in v2.1.8
2 participants
@kavir1698 @minottic