-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Pagination): replace toggleTemplateProps with paginationToggleTe… #201
feat(Pagination): replace toggleTemplateProps with paginationToggleTe… #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only nit is using rename
vs remove
, but not a blocker.
Gonna blame @wise-king-sullyman's generator 😜 |
I mean, the old prop was removed was it not 😂 Really though I'd be on board with standardizing on calling a rename mod a |
@wise-king-sullyman I suppose the generator could check if the replacement is empty str to determine and do both ways |
Yeah I'm still planning to circle back to the generator when I get a free moment, restructure things a bit and add a few other common use cases like that in a more straightforward way. That would definitely be a quicker way to implement replace and remove functionality though. I might throw up a quick PR for that. |
@wise-king-sullyman but can you pr review? 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@@ -9,7 +9,7 @@ const lowerCasedComponentName = componentName[0].toLowerCase() + componentName.s | |||
const newRuleName = `${lowerCasedComponentName}-remove-${oldPropName}` | |||
|
|||
if (!componentName || !oldPropName || !newPropName || !referencePR) { | |||
console.log('usage: node generate [componentName] [oldPropName] [newPropName] [referencePR]'); | |||
console.log('usage: node generate-replace-prop-v5 [componentName] [oldPropName] [newPropName] [referencePR]'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, nice catch.
closes: #147