Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination - renamed prop #147

Closed
evwilkin opened this issue Dec 7, 2022 · 0 comments · Fixed by #201
Closed

Pagination - renamed prop #147

evwilkin opened this issue Dec 7, 2022 · 0 comments · Fixed by #201
Assignees
@gitdallas
Labels
codemod pf5 codemod for p4 to p5 transition
Milestone
2023.01

Comments

@evwilkin
Copy link
Member

evwilkin commented Dec 7, 2022

Follow up to breaking change PR [link]

In the pagination component we've renamed a prop from ToggleTemplateProps to PaginationToggleTemplateProps and should push this change out to consumers' code.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitdallas gitdallas

Labels
codemod pf5 codemod for p4 to p5 transition
Projects
PatternFly Issues
Archived in project
Milestone
2023.01
Development

Successfully merging a pull request may close this issue.

feat(Pagination): replace toggleTemplateProps with paginationToggleTe… gitdallas/pf-codemods
3 participants
@gitdallas @evwilkin @nicolethoen