Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tile): Adds documentation to React examples. #9535

Merged
merged 1 commit into from
Sep 12, 2023
Merged

docs(tile): Adds documentation to React examples. #9535

merged 1 commit into from
Sep 12, 2023

Conversation

edonehoo
Copy link
Contributor

Makes progress on patternfly/patternfly-org#2990

Intended to replace #9208

@edonehoo edonehoo self-assigned this Aug 24, 2023
@edonehoo edonehoo marked this pull request as draft August 24, 2023 17:39
@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 24, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9535.surge.sh

A11y report: https://patternfly-react-pr-9535-a11y.surge.sh

@tlabaj tlabaj mentioned this pull request Aug 24, 2023
Closed
andrew-ronaldson
andrew-ronaldson approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

tlabaj
tlabaj approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edonehoo edonehoo marked this pull request as ready for review September 12, 2023 14:04
@edonehoo
Copy link
Contributor Author

@andrew-ronaldson or @tlabaj it looks like this one is ready to merge!

@andrew-ronaldson andrew-ronaldson merged commit 610d910 into patternfly:main Sep 12, 2023
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.1.1-prerelease.8
  • @patternfly/react-core@5.1.1-prerelease.8
  • @patternfly/react-docs@6.1.1-prerelease.9
  • demo-app-ts@5.1.1-prerelease.7
  • @patternfly/react-table@5.1.1-prerelease.8

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlabaj tlabaj tlabaj approved these changes

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes

Assignees

@edonehoo edonehoo

Labels
Content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edonehoo @patternfly-build @andrew-ronaldson @tlabaj