Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tile): Adds content to tile component #9208

Closed
wants to merge 14 commits into from

Conversation

KaelanKhiatani
Copy link

@KaelanKhiatani KaelanKhiatani commented May 30, 2023

Makes progress on patternfly/patternfly-org#2990
Adds content for tile and select next components.

@patternfly-build
Copy link
Contributor

patternfly-build commented May 30, 2023

@KaelanKhiatani KaelanKhiatani changed the title Adds content to Tile examples docs(tile): Adds content to tile component Jul 6, 2023
@edonehoo
Copy link
Contributor

@KaelanKhiatani looks like some of my previous feedback is still pending - maybe because of our rebase. Can you incorporate that and push an update? You can commit directly from the conversation/comments above, or just make all of the changes locally and add a new commit

KaelanKhiatani and others added 4 commits July 11, 2023 15:15
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
packages/react-core/src/components/Tile/examples/Tile.md Outdated Show resolved Hide resolved
Copy link
Contributor

@edonehoo edonehoo Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with v5, the "next" components are promoted, so this file is now contained here: https://github.com/patternfly/patternfly-react/blob/main/packages/react-core/src/components/Select/examples/Select.md

This is the link to the v5 page: https://staging.patternfly.org/components/menus/select

In VS code, make sure you're up to date with the 'main' branch and that the Select.md file matches what you see at these links, with the content you're adding. This may be something easier to look at together on a call?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

& content is missing from a few examples, but if you need help drafting that just lmk!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this tomorrow.

packages/react-core/src/next/components/Select.md Outdated Show resolved Hide resolved
KaelanKhiatani and others added 6 commits July 11, 2023 16:12
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com>
@tlabaj
Copy link
Contributor

tlabaj commented Aug 24, 2023

Closing the PR. The issue will be resolved in PR #9535

@tlabaj tlabaj closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants