Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datalist): removed deprecated drag props #8169

Closed
wants to merge 6 commits into from

Conversation

KhanShaheb34
Copy link
Contributor

What: Closes #8086

gitdallas and others added 6 commits October 5, 2022 09:52
 - eslint-plugin-patternfly-react@4.80.4
 - @patternfly/react-docs@5.102.29
 - @patternfly/react-inline-edit-extension@4.86.25
 - @patternfly/react-table@4.111.2
* next(Select): add select using menu components

* add id

* fix duplicate id

* pr feedback

* add ouia props

* update ta data, update ta behavior to better match select

* remove example, update structure on grouped
@gefgu
Copy link
Contributor

gefgu commented Oct 5, 2022

@KhanShaheb34 super thanks for your contribution 😉! I've noticed your Pull Request includes a lot of commits (from multiple authors) instead of only the one required for this change. Could you please update this PR to include only your commit?

@KhanShaheb34
Copy link
Contributor Author

Sure @gefgu

@tlabaj tlabaj added breaking change 💥 this change requires a major release and has API changes. PF5 labels Oct 6, 2022
@tlabaj
Copy link
Contributor

tlabaj commented Oct 13, 2022

Looks like you need to rebase against the v5 branch to get rid of all those extra diff files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change 💥 this change requires a major release and has API changes. PF5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants