Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataList] - [remove deprecated props ] #8086

Closed
tlabaj opened this issue Sep 26, 2022 · 4 comments · Fixed by #8388
Closed

[DataList] - [remove deprecated props ] #8086

tlabaj opened this issue Sep 26, 2022 · 4 comments · Fixed by #8388
Assignees
@thatblindgeye
Labels
breaking change 💥 this change requires a major release and has API changes. good first issue PF5
Milestone
2022.16

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Sep 26, 2022 •
edited
Loading

Describe the problem
A clear and concise description of the problem. Which components are affected?

Remove the following deprecated props and any associated logic from DataList

  • onDragFinish
  • onDragStart
  • onDragMove
  • onDragCancel
  • itemOrder
@tlabaj tlabaj added bug needs triage breaking change 💥 this change requires a major release and has API changes. and removed bug labels Sep 26, 2022
@tlabaj tlabaj added this to the 2022.14 milestone Sep 26, 2022
@KhanShaheb34
Copy link
Contributor

Can I work on this one?

@KhanShaheb34 KhanShaheb34 mentioned this issue Oct 5, 2022
Closed
@tlabaj
Copy link
Contributor Author

tlabaj commented Oct 5, 2022

Sure. Make sure your work is agains the v5 branch.

@mcarrano mcarrano modified the milestones: 2022.14, 2022.15 Oct 21, 2022
@mcarrano mcarrano modified the milestones: 2022.15, 2022.16 Nov 11, 2022
@nicolethoen
Copy link
Contributor

@KhanShaheb34 Let me know if you still were planning on working on this, but I've unassigned you for now in case other people want to take a peek

@thatblindgeye thatblindgeye mentioned this issue Nov 23, 2022
Merged
@nicolethoen nicolethoen linked a pull request Nov 30, 2022 that will close this issue
chore(DataList): removed deprecated props and logic #8388
Merged
@nicolethoen
Copy link
Contributor

Closed by #8388

@nicolethoen nicolethoen added the PF5 label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
breaking change 💥 this change requires a major release and has API changes. good first issue PF5
Projects
PatternFly Issues
Archived in project
Milestone
2022.16
Development

Successfully merging a pull request may close this issue.

chore(DataList): removed deprecated props and logic thatblindgeye/patternfly-react
5 participants
@mcarrano @nicolethoen @KhanShaheb34 @tlabaj @thatblindgeye