Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-virtualized-extension docs): add filterable demo, fix for filtering+scrolling #4389

Merged
merged 4 commits into from
Jun 19, 2020
Merged

feat(react-virtualized-extension docs): add filterable demo, fix for filtering+scrolling #4389

merged 4 commits into from
Jun 19, 2020

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jun 15, 2020 •
edited
Loading

What: fix for filtering in #4311

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 15, 2020 •
edited
Loading

PF4 preview: https://patternfly-react-pr-4389.surge.sh
A11y report: https://patternfly-react-pr-4389-coverage.surge.sh

@kmcfaul kmcfaul mentioned this pull request Jun 15, 2020
Closed
@kmcfaul
Copy link
Contributor Author

kmcfaul commented Jun 17, 2020 •
edited
Loading

Updated demo to include WindowScroller to better match the OpenShift use case.

Discovered an open bug in react-virtualized that was causing the intermittent scroll gap when filtering with WindowScroller/Grid. Reverting VirtualGrid to a previous iteration fixes this issue, though I'm unsure if it will introduce other bugs in the future.

@kmcfaul kmcfaul force-pushed the virtualized-table branch from 1edab95 to 0eb8f34 Compare June 17, 2020 21:46
@kmcfaul kmcfaul changed the title feat(react-virtualized-extension docs): add filterable demo [WIP] feat(react-virtualized-extension docs): add filterable demo, fix for filtering+scrolling Jun 18, 2020
jcaianirh
jcaianirh approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tlabaj
tlabaj approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 5b3d07d into patternfly:master Jun 19, 2020
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-docs@5.4.1
  • @patternfly/react-virtualized-extension@4.4.0

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaianirh jcaianirh jcaianirh approved these changes

@tlabaj tlabaj tlabaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmcfaul @patternfly-build @jcaianirh @tlabaj