Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Rendering issues of virtualized table causing performance and display issues in OpenShift #4311

Closed
jcaianirh opened this issue May 29, 2020 · 3 comments
Assignees
Milestone

Comments

@jcaianirh
Copy link
Contributor

jcaianirh commented May 29, 2020

Describe the issue. What is the expected and unexpected behavior?
Specifically, pf4 tables vs pf3 tables scrolling is noticeably degraded. The PF4 table scrolling is choppy and jumpy by comparison.

This issue is reproducible with the Patternfly sample paes. The scrolling is re-rendering rows on every pixel movement. (See the screenshot attached) This re render did not occur on pf3 tables.

Display of rerender of every row on scroll:
virtualscroller

Display of render issue on filter
render-issue

Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.

**Is this a bug or enhancement?
Openshift Bugs related: https://issues.redhat.com/browse/CONSOLE-1532
https://bugzilla.redhat.com/show_bug.cgi?id=1819752
https://bugzilla.redhat.com/show_bug.cgi?id=1795305
https://bugzilla.redhat.com/show_bug.cgi?id=1805918
cc: @janwright73

@tlabaj tlabaj modified the milestones: Prioritized Backlog, 2020.08 May 29, 2020
@jcaianirh jcaianirh changed the title Table: Rendering issues of pf table causing performance and display issues in OpenShift Table: Rendering issues of virtualized table causing performance and display issues in OpenShift Jun 3, 2020
@kmcfaul
Copy link
Contributor

kmcfaul commented Jun 15, 2020

Re: the re-rendering, both pf3 and pf4 source their virtualized scrolling from the react-virtualized library with minor changes in pf4's copy that shouldn't impact performance. The examples in the docs have a small overscan index of 2 so that could be why they update more often. It is possible the difference lies in Table, so I am continuing to investigate.

Re: the filtering bug, I have not been able to reproduce this behavior so far after adding a filterable table demo to the virtualized docs (can be looked at in this WIP PR with surge). Are you getting any console errors/warnings when the white space appears?

@jcaianirh
Copy link
Contributor Author

@kmcfaul with the filtering issue: no console errors or warnings when this occurs. But one other clue, is that subsequent scrolling on the page rerenders the component correctly, and the blank space is removed.

@tlabaj
Copy link
Contributor

tlabaj commented Jun 19, 2020

closed by #4389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants