feat(example): Add dark theme toggle button & change background color #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
light-theme
branch
from
66b1ff8 to
a87f288
Compare
|
I removed the background color after discussing with @mcoker . The gray color was throwing off the styles for multiple components. I added a border on the right of the left nav to make sure there still a visual separation between the nav and main.
new BG color: |
|
@ibolton336 you are the man! |
|
PatternFly-React preview: https://1212-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4049
💛 - Coveralls |
ibolton336
force-pushed
the
light-theme
branch
from
a87f288 to
07241f7
Compare
jschuler
reviewed
Jan 17, 2019
| @@ -0,0 +1,11 @@ | |||
| html, | |||
There was a problem hiding this comment.
This file should be removed
ibolton336
force-pushed
the
light-theme
branch
from
07241f7 to
ab25844
Compare
jschuler
approved these changes
Jan 17, 2019
tlabaj
reviewed
Jan 17, 2019
tlabaj
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
closes #957
Additional issues: