Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples should have Light/Dark Mode #957

Closed
christiemolloy opened this issue Nov 26, 2018 · 1 comment · Fixed by #1212
Closed

Examples should have Light/Dark Mode #957

christiemolloy opened this issue Nov 26, 2018 · 1 comment · Fixed by #1212
Assignees
@ibolton336
Labels
Infrastructure

Comments

@christiemolloy
Copy link
Member

To reflect what is in Core we should have a light/dark mode toggle in React. As of right now, it is only pulling in the light versions and as we progress we will have more examples of components that will exist on light and dark backgrounds.
@dgutride
Copy link
Member

dgutride commented Jan 8, 2019

@ibolton336 - do you want to take a look at this?

@dgutride dgutride modified the milestone: 1.0.0-alpha.7 Jan 8, 2019
@ibolton336 ibolton336 self-assigned this Jan 10, 2019
@tlabaj tlabaj added the p1 label Jan 15, 2019
@ibolton336 ibolton336 mentioned this issue Jan 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibolton336 ibolton336

Labels
Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(example): Add dark theme toggle button & change background color ibolton336/patternfly-react
4 participants
@dgutride @ibolton336 @christiemolloy @tlabaj