docs(CodeEditor): add configuration example from OCP

[logonoff]

What: Closes #11878

Additional issues: openshift/console#15254

[rebeccaalpert]

Just one comment about a prop. I'm going to ping Eric to get his opinion on accessibility. I had a go at looking at this with VoiceOver and axe, but he knows more about it. I'll see if design needs to weigh in on the alignment or anything.

[rebeccaalpert]

Bugged Andrew off-GitHub to see if this needs design review.

[rebeccaalpert]

Andrew will review once #12032 merges and Surge is back. May want to adjust alignment.

[thatblindgeye]

Overall this looks great 🆒 🐱 a11y wise I think things look good, just some comments in files or below

• Not entirely sure about not including an explicit "save" button in the Modal. It's an implementation that already exists in general, I'd just want to be cautious about potentially creating confusion. Since it's an example we can probably wait to see if any feedback comes in on it, but adding a "save" button or some sort of verbiage at the top to mention "settings will autosave" or something could be worth considering at some point in the future

[rebeccaalpert]

I think if you rebase against main, you'll pull in #12032 and be able to get the Surge link for @andrew-ronaldson. It is now merged.

[patternfly-build]

Preview: https://pf-react-pr-12026.surge.sh

A11y report: https://pf-react-pr-12026-a11y.surge.sh

[andrew-ronaldson]

Could you put the icons in the heading instead? We do that in other components with a span I think.

[logonoff]

Could you put the icons in the heading instead? We do that in other components with a span I think.

how's this?

before:

[rebeccaalpert]

@andrew-ronaldson Feelings?

[rebeccaalpert]

We're in code freeze ahead of release, but will try to merge this once it lifts!